Pagination does't take port number in account

Hello,

This part in Pagination.php:


// Build url string from parts
$string = $url['scheme'] . '://';
$string .= $url['host'];
$string .= $url['path'] . ($this->seo_friendly_url ? '/' : '');
$string .= isset ($url['query']) ? '?' . $url['query'] : '';
return $string;


Should be:


// Build url string from parts
$string = $url['scheme'] . '://';
$string .= $url['host'];

if (isset ($url['port'])) {
$string .= ':'.$url['port'];
}

$string .= $url['path'] . ($this->seo_friendly_url ? '/' : '');
$string .= isset ($url['query']) ? '?' . $url['query'] : '';
return $string;


PS: Why don't you put the official repo on github? This would be much easier to report bugs :)

Comments

  • Thanks for reporting this.

    We have a public GitHub repo, it's just read-only at the moment. We are debating on opening it up so that people can contribute. So far, not too many people have really expressed interest in contributing so we haven't given it much priority.
Sign In or Register to comment.